gltfio: add nominal support for flat shading. #2115
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This "fixes" the new animated Fox model in the glTF conformance suite. As per the glTF spec, we now generate per-face normals for the case where normals are not specified in the model. Note that true flat shading (i.e. flat interpolation) is not a requirement in the glTF spec, since some Khronos members advocate for WebGL 1.0 compatibility. Fixes #2088.
romainguy
approved these changes
Feb 10, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This "fixes" the new animated Fox model in the glTF conformance suite. As per the glTF spec, we now generate per-face normals for the case where normals are not specified in the model.
Note that true flat shading (i.e. flat interpolation) is not a requirement in the glTF spec, since some Khronos members advocate for WebGL 1.0 compatibility.
Fixes #2088.